Database.js ➔ close - Code Metrics - Inspection of "Fix database," - mgonzaledk/node-express-apirest - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 152bc9...7b1700 )

by Miguel Ángel

created 2019-01-21 11:32 UTC

Database.js ➔ close A

↳ Parent: Model/Database.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	2
b	0
f	0
nc	1
dl	0
loc	11
rs	10
nop	0

1 Function

Rating	Name	Duplication	Size	Complexity
A	Database.js ➔ ... ➔ ???	0	9	1

const mysql = require('mysql')

class Database {
    constructor(config) {
        this.connection = mysql.createConnection(config);
    }

    query(sql, args) {
        return new Promise((resolve, reject) => {
            this.connection.query(sql, args, (error, rows) => {
                if (error) {
                    return reject(error)
                }

                return resolve(rows)
            })
        })
    }

    close() {
        return new Promise((resolve, reject) => {
            this.connection.end( err => {

                if (error) {

                    return reject(error)
                }

                return resolve()
            })
        })
    }
}

Database.execute = function (config, callback) {
    const database = new Database(config)

    return callback(database).then(
        result => database.close().then(() => result),
        error => database.close().then(() => { throw error })
    )
}

module.exports = {
    Database
}


1			const mysql = require('mysql')
2
3			class Database {
4			constructor(config) {
5			this.connection = mysql.createConnection(config);
6			}
7
8			query(sql, args) {
9			return new Promise((resolve, reject) => {
10			this.connection.query(sql, args, (error, rows) => {
11			if (error) {
12			return reject(error)
13			}
14
15			return resolve(rows)
16			})
17			})
18			}
19
20			close() {
21			return new Promise((resolve, reject) => {
22			this.connection.end( err => {
			0 ignored issues – show Unused Code introduced 2019-01-21 11:34 UTC by Report Bug Copy Issue Report The parameter `err` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
23			if (error) {
			0 ignored issues – show Best Practice introduced 2019-01-21 11:34 UTC by Report Bug Copy Issue Report If you intend to check if the variable `error` is declared in the current environment, consider using `typeof error === "undefined"` instead. This is safe if the variable is not actually declared. Loading history...
24			return reject(error)
25			}
26
27			return resolve()
28			})
29			})
30			}
31			}
32
33			Database.execute = function (config, callback) {
34			const database = new Database(config)
35
36			return callback(database).then(
37			result => database.close().then(() => result),
38			error => database.close().then(() => { throw error })
39			)
40			}
41
42			module.exports = {
43			Database
44			}
45

mgonzaledk / node-express-apirest

Push — master ( 152bc9...7b1700 )

Database.js ➔ close A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like